BC-8551 - Delete const ALL_ENTITIES #5446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage place. -> Currently some parts should be broken.
bergatco
changed the title
…schul-cloud/schulcloud-server into BC-8551-remove-all-entities
CeEv
commented
Feb 4, 2025
apps/server/src/modules/deletion-console/deletion-execution.console.spec.ts
Show resolved
Hide resolved
CeEv
commented
Feb 4, 2025
| import path from 'path'; | ||
| import { ENTITIES } from './management.entity.imports'; | ||
|
|
||
| const migrationsPath = path.resolve(__dirname, '..', '..', 'migrations', 'mikro-orm'); // TODO: Warum ist das hier überhaupt relevant? |
There was a problem hiding this comment.
// TODO: Import Reihenfolge sieht falsch aus ...IDM prüfen.
// TODO: Warum ist das hier überhaupt relevant?
Kann raus
There was a problem hiding this comment.
Imports schein richtig zu sein
Zeile 17 zeigt wo migrations Files liegen
CeEv
commented
Feb 4, 2025
| import { createConfigModuleOptions } from '@shared/common/config-module-options'; | ||
| import { ConsoleModule } from 'nestjs-console'; | ||
| import path from 'path'; | ||
| import { ENTITIES } from './management.entity.imports'; |
There was a problem hiding this comment.
Hier brauchen wir alle Entities. Z.B. auch fileRecord, sollten wir aktuell eine Migration schreiben, oder eine existierende ausführen. Daher die Überlegung mit dem regex.
CeEv
commented
Feb 4, 2025
CeEv
commented
Feb 4, 2025
CeEv
commented
Feb 4, 2025
…pdate database management console methods to public
CeEv
commented
Feb 5, 2025
Comment on lines
+5
to
+7
| import { FilesStorageClientModule } from '@infra/files-storage-client'; | ||
| import { RabbitMQWrapperModule } from '@infra/rabbitmq'; | ||
| import { MikroOrmModule } from '@mikro-orm/nestjs'; | ||
| import { FilesStorageClientModule as FilesMetadataClientModule } from '@modules/files-storage-client'; |
There was a problem hiding this comment.
Hier sind beide file-storage-clients drin.
CeEv
commented
Feb 5, 2025
…d update deletion logic
…ge-client modules
CeEv
commented
Feb 5, 2025
apps/server/src/modules/deletion-console/deletion-console.app.module.ts
Outdated
Show resolved
Hide resolved
CeEv
commented
Feb 5, 2025
apps/server/src/modules/deletion-console/deletion-execution.console.spec.ts
Outdated
Show resolved
Hide resolved
CeEv
commented
Feb 5, 2025
apps/server/src/modules/files-storage-client/files-storage-client.module.ts
Outdated
Show resolved
Hide resolved
…rvice and update deletion logic" This reverts commit 3f8f5f8.
SevenWaysDP
approved these changes
Feb 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each app.module should import the entities they need directly. To make dependencies explicit. The linter rules must change in a way that allow the imports.
Links to Tickets or other pull requests
JIRA :
Deployments :
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.